Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swipe-back): gesture rtl setting is reactive #26795

Merged
merged 4 commits into from
Feb 16, 2023
Merged

fix(swipe-back): gesture rtl setting is reactive #26795

merged 4 commits into from
Feb 16, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 14, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26794

The RTL setting is checked on creation of the swipe-back gesture. This means that if a user's text direction changes mid-session (such as by changing a locale on the phone) then the swipe back gesture will potentially run in the wrong direction. For example, if the text direction was LTR on load, the swipe back gesture will run from left to run even when the text direction is updated to RTL.

What is the new behavior?

  • The RTL setting is checked at the beginning of every swipe gesture

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Feb 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Feb 14, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review February 14, 2023 15:55
@liamdebeasi liamdebeasi requested a review from a team February 15, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: opened page does not properly react on changes of dir attribute
2 participants