fix(button): wrap text by default #28682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapsandapps
commented
Dec 11, 2023
There was a problem hiding this comment.
We could add the nowrap class to these buttons so they don't wrap, if that's preferred over updating the snapshots.
There was a problem hiding this comment.
I am okay with keeping this. I think we should avoid custom css where possible.
mapsandapps
changed the title
mapsandapps
requested review from
averyjohnston
and removed request for
a team
brandyscarney
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
I am okay with keeping this. I think we should avoid custom css where possible.
Co-authored-by: Brandy Carney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #8700
What is the current behavior?
Button text is truncated by default.
What is the new behavior?
Does this introduce a breaking change?
Starting in Ionic Framework 7.2, we encouraged developers to opt-in to text wrapping in buttons by setting
ion-text-wrap.This PR is targeting Ionic Framework v8, where text wrapping of buttons will be the default behavior.
This may cause visual changes across apps using Ionic Framework. Buttons with long text may now be taller than before, leading to layout shifts.
If developers wish to prevent text wrapping, they may use the .ion-text-nowrap class.