Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toggle): update styles to iOS 17 specs #28722

Merged
merged 14 commits into from
Dec 21, 2023
Merged

feat(toggle): update styles to iOS 17 specs #28722

merged 14 commits into from
Dec 21, 2023

Conversation

mapsandapps
Copy link
Contributor

@mapsandapps mapsandapps commented Dec 18, 2023 •
edited by brandyscarney
Loading

Issue number: Internal

What is the current behavior?

The Toggle styles do not match iOS 17.

iOS 17 Screenshot New Design Ionic v7
iOS Toggle Proposed Toggle Ionic Toggle

What is the new behavior?

  • The Toggle handle box shadow matches iOS 17 specs
  • The Toggle height matches iOS 17 specs

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 18, 2023
@mapsandapps mapsandapps changed the title fix(toggle): match new iOS version feat(toggle): match new iOS version Dec 18, 2023
@mapsandapps mapsandapps changed the title feat(toggle): match new iOS version feat(toggle): update styles to iOS 17 specs Dec 18, 2023
@mapsandapps mapsandapps marked this pull request as ready for review December 18, 2023 22:01
@mapsandapps mapsandapps marked this pull request as draft December 19, 2023 20:23
@mapsandapps mapsandapps marked this pull request as ready for review December 21, 2023 16:08
@mapsandapps mapsandapps requested review from brandyscarney and a team December 21, 2023 16:08
@mapsandapps mapsandapps merged commit 0ce0693 into FW-4845 Dec 21, 2023
44 checks passed
@mapsandapps mapsandapps deleted the FW-5740 branch December 21, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mapsandapps @brandyscarney @Ionitron