Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): improve reliability of main content not being scrollable when menu opens #28829

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 15, 2024

Issue number: resolves #28399


What is the current behavior?

As part of #26976 I fixed an issue where pointer-events: none was not applied until after the menu open gesture finishes. This resolved a bug where scrolling was latching after the menu gesture starts.

However, I did not account for the edge case where scrolling latches before pointer-events: none is applied in the DOM. Since scrolling has already latched then pointer-events: none does not change the scrolling behavior. This can happen if a user swipes up and to the right from the left edge of the screen.

What is the new behavior?

  • overflow-y: hidden is now applied to the scrollable content which will interrupt any scrolling when the menu is open.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Testing:

This bug fixes a timing issue where scrolling latches on the main content as the menu tries to open. As a result, I am unable to write reliable automated tests for this. Reviewers should perform the following test on iOS and Android physical devices:

  1. Open src/components/menu/test/basic.
  2. Add enough elements to the main page content such that it scrolls (I added a list with items).
  3. On each device, attempt to scroll the main content while also opening the menu on the starting edge of the screen.

Scrolling on the main content should not happen if the menu opens.

Dev build: 7.6.5-dev.11705341148.1a550d3b

@liamdebeasi liamdebeasi changed the title fix(menu): improve reliability of main content not being scrollable w… fix(menu): improve reliability of main content not being scrollable when menu opens Jan 15, 2024
@github-actions github-actions bot added the package: core @ionic/core package label Jan 15, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review January 15, 2024 18:10
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my physical Android and iOS devices, works great 👍

@liamdebeasi liamdebeasi added this pull request to the merge queue Jan 23, 2024
Merged via the queue into main with commit 9603a4d Jan 23, 2024
56 checks passed
@liamdebeasi liamdebeasi deleted the FW-5448 branch January 23, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: content is scrollable when opening menu on ios
2 participants