feat(input,textarea,select): add --highlight-height variable #29090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue number: internal --------- ## What is the current behavior? In v7, using the legacy syntax, the height of the highlight on an item could be adjusted using the `--highlight-height` variable. This variable was not added to input and therefore would not work using the modern syntax. ## What is the new behavior? Adds the `--highlight-height` variable so that developers can customize this height in `md` mode. Since the highlight element is not added for `ios` mode, this variable won't do anything for `ios`. Note that this diverges from the v7 behavior, where setting `--highlight-height` enabled the highlight for `ios`. A design document outlining this has been proposed here: ionic-team/ionic-framework-design-documents#252 ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: ionitron <[email protected]>
Issue number: internal --------- ## What is the current behavior? In v7, using the legacy syntax, the height of the highlight on an item could be adjusted using the `--highlight-height` variable. This variable was not added to textarea and therefore would not work using the modern syntax. ## What is the new behavior? Adds the `--highlight-height` variable so that developers can customize this height in `md` mode. Since the highlight element is not added for `ios` mode, this variable won't do anything for `ios`. Note that this diverges from the v7 behavior, where setting `--highlight-height` enabled the highlight for `ios`. A design document outlining this has been proposed here: ionic-team/ionic-framework-design-documents#252 ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: ionitron <[email protected]>
Issue number: internal --------- ## What is the current behavior? In v7, using the legacy syntax, the height of the highlight on an item could be adjusted using the `--highlight-height` variable. This variable was not added to select and therefore would not work using the modern syntax. ## What is the new behavior? Adds the `--highlight-height` variable so that developers can customize this height in `md` mode. Since the highlight element is not added for `ios` mode, this variable won't do anything for `ios`. Note that this diverges from the v7 behavior, where setting `--highlight-height` enabled the highlight for `ios`. A design document outlining this has been proposed here: ionic-team/ionic-framework-design-documents#252 ## Does this introduce a breaking change? - [ ] Yes - [x] No --------- Co-authored-by: ionitron <[email protected]>
sean-perkins
requested review from
thetaPC and
brandyscarney
and removed request for
a team
|
The individual feature PRs have been approved (by me). This PR is the combined branch of all the changes for input, textarea and select. |
averyjohnston
approved these changes
Feb 28, 2024
|
Removing myself as a reviewer since I implemented the original PRs. |
thetaPC
requested changes
Mar 5, 2024
...light/select.e2e.ts-snapshots/select-no-fill-custom-highlight-md-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...light/select.e2e.ts-snapshots/select-outline-custom-highlight-md-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...ghlight/select.e2e.ts-snapshots/select-solid-custom-highlight-md-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
In v7, using the legacy syntax, the height of the highlight on an item could be adjusted using the
--highlight-heightvariable. This variable was not added to input and therefore would not work using the modern syntax.What is the new behavior?
Adds the
--highlight-heightvariable toion-input,ion-textareaandion-selectso that developers can customize this height inmdmode. Since the highlight element is not added foriosmode, this variable won't do anything forios. Note that this diverges from the v7 behavior, where setting--highlight-heightenabled the highlight forios. A design document outlining this has been proposed here: https://github.com/ionic-team/ionic-framework-design-documents/pull/252Does this introduce a breaking change?
Other information