perf(datetime): calendar body shows immediately in modal on ios #29163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
averyjohnston and
sean-perkins
as code owners
averyjohnston
approved these changes
Mar 15, 2024
Co-authored-by: Amanda Johnston <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #24542
What is the current behavior?
WebKit has a quirk where IntersectionObserver callbacks are delayed until after an accelerated animation finishes if the "root" specified in the config is the browser viewport (the default behavior if "root" is not specified) This means that when presenting a datetime in a modal on iOS the calendar body appears blank until the modal animation finishes.
What is the new behavior?
.intersection-trackerelement inside of datetime. This element has a dimension of 0x0 so it should not affect component layout or functionality.I opted to add this element instead of re-using an existing element because the existing elements are not guaranteed to always be in the DOM due to different datetime presentation styles.
mainRPReplay_Final1710449954.MP4
RPReplay_Final1710449919.MP4
Does this introduce a breaking change?
Other information
Dev build:
7.8.1-dev.11710449785.14ebd5a0