fix(range): disable scroll when range is being dragged #29241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
Jul 18, 2024
| @@ -325,7 +325,8 @@ export class Range implements ComponentInterface { | |||
| this.setupGesture(); | |||
| } | |||
|
|
|||
| this.contentEl = findClosestIonContent(this.el); | |||
| const ionContent = findClosestIonContent(this.el); | |||
There was a problem hiding this comment.
The scroll target test was failing because we didn't take into account that there might be a custom scroll target.
thetaPC
commented
Jul 18, 2024
| @@ -418,7 +419,7 @@ export class Range implements ComponentInterface { | |||
| * | |||
| * This only needs to be done once. | |||
| */ | |||
| if (contentEl && this.initialContentScrollY === undefined) { | |||
| if (contentEl && this.pressedKnob === undefined) { | |||
There was a problem hiding this comment.
The scroll was never being disabled which lead to flaky results.
thetaPC
commented
Jul 18, 2024
| @@ -99,31 +107,6 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => | |||
|
|
|||
| expect(rangeEndSpy.length).toBe(1); | |||
| }); | |||
|
|
|||
| // TODO FW-2873 | |||
| test.skip('should not scroll when the knob is swiped', async ({ page, skip }) => { | |||
There was a problem hiding this comment.
Moved this test to it's own test page to properly test the scroll since the basic page didn't have enough content to scroll on.
thetaPC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There are a few tests that were disabled due to being flaky from gestures.
What is the new behavior?
While fixing the tests, I found a bug that the scroll was never being disabled on scroll. Additionally, we were not taking into account that a custom scroll target could be used so it was never disabled either.
ion-contentor a custom scroll target.Does this introduce a breaking change?
Other information
Preview for
ion-contentPreview for custom scroll target
How to test: