refactor(react): export InputInputEventDetail type #29512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
screenshot of conversation with Liam |
|
Thank you for submitting the PR! Is there an issue opened that ties to this PR? |
|
I looked just now and didn't find one! Hope this works (first PR ever) |
|
Congrats on your first PR!!! 🎉 We would need an open issue to be tied to this PR so we can get as much context as possible to provide a review. You can fill out this form to submit a bug. Once you have created one, please add it to the issue number under the PR description. Thank you! |
|
Great, updated! |
thetaPC
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29518
What is the current behavior?
IonInput in React apps can't import the correct type for typescript.
What is the new behavior?
Since it is in the file exported, people using IonInput can import the correct type.
Does this introduce a breaking change?
Other information
Liam DeBeasi told me it was a bug a couple days ago and pointed out to where it needed to be added.