Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): add onPointerDown, onTouchEnd, add onTouchMove #29736

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix(react): add onPointerDown, onTouchEnd, add onTouchMove #29736

merged 2 commits into from
Aug 2, 2024

Conversation

Stev24
Copy link
Contributor

@Stev24 Stev24 commented Jul 26, 2024 •
edited by sean-perkins
Loading

Issue number: resolves #29174

What is the current behavior?

React throws tab errors with IonTabButton when binding to onPointerDown, onTouchEnd and onTouchMove

What is the new behavior?

  • Adds missing type definitions for onPointerDown, onTouchEnd and onTouchMove to IonTaButton
  • React does not throw type errors when binding callback functions to these events

Does this introduce a breaking change?

  • Yes
  • No

@Stev24 Stev24 requested a review from a team as a code owner July 26, 2024 21:42
@Stev24 Stev24 requested a review from gnbm July 26, 2024 21:42
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2024 5:15am

@github-actions github-actions bot added the package: react @ionic/react package label Jul 26, 2024
@sean-perkins sean-perkins changed the title fix(ionTabButton): add onPointerDown, add onTouchEnd, add onTouchMove fix(react): add onPointerDown, add onTouchEnd, add onTouchMove Aug 1, 2024
@sean-perkins sean-perkins changed the title fix(react): add onPointerDown, add onTouchEnd, add onTouchMove fix(react): add onPointerDown, onTouchEnd, add onTouchMove Aug 1, 2024
sean-perkins
sean-perkins approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes locally, thanks for your contribution!

I'll add a core team member to review so that it can be merged. My review is the equivalent of moral support when it comes to merging 😄

@sean-perkins sean-perkins requested review from brandyscarney and thetaPC and removed request for gnbm August 1, 2024 18:17
thetaPC
thetaPC approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@thetaPC thetaPC added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@thetaPC thetaPC added this pull request to the merge queue Aug 2, 2024
Merged via the queue into ionic-team:main with commit bfee3cd Aug 2, 2024
48 of 51 checks passed
@thetaPC thetaPC mentioned this pull request Aug 2, 2024
Closed
3 tasks
@gramirez-vic gramirez-vic mentioned this pull request Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@sean-perkins sean-perkins sean-perkins approved these changes

@brandyscarney brandyscarney Awaiting requested review from brandyscarney

Assignees
No one assigned
Labels
package: react @ionic/react package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: IonTabButton doesn't have default HTML event attributes typed
3 participants
@Stev24 @thetaPC @sean-perkins