Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radio): display as block when justify or alignment properties are defined #29801

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 26, 2024

Issue number: internal


What is the current behavior?

When adding the justify or alignment property to an ion-radio it does not change the design because the radio is displayed inline.

What is the new behavior?

This is doing the same thing as #29783

  • Change the radio's display property to block when the justify or alignment property is set.
  • Set the default justify-content style to space-between so that a radio with width: 100% set without justify or alignment set will still have the same default
  • Modifies the label-placement e2e test to remove the explicit width as setting the property will make them full-width
  • Adds two examples to the label-placement e2e test of labels that do not have justify set but use width: 100% to ensure they are working as expected without it
  • Adds one example to the label-placement e2e test of a long label that uses justify to ensure it still wraps properly (this existed in the checkbox test but not radio)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 8:04pm

@github-actions github-actions bot added the package: core @ionic/core package label Aug 26, 2024
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 18b02b3 into feature-8.3 Aug 29, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-11044 branch August 29, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants