Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate app.getComponentById in favor of @ViewChild #6199

Closed
adamdbradley opened this issue Apr 17, 2016 · 2 comments
Closed

Deprecate app.getComponentById in favor of @ViewChild #6199

adamdbradley opened this issue Apr 17, 2016 · 2 comments
Assignees
@adamdbradley
Milestone
2.0.0-beta.7

Comments

@adamdbradley
Copy link
Contributor

app.getComponentById was created before @ViewChild and @ContentChild could query specific components by an id. Now that those have stabilized, our custom solution may no longer be needed, and is probably not the recommended way. Additionally, app.getComponentById was largely needed for menus, but menus now have an improved way to find references to specific menus.

Research if it's possible to completely deprecate app.getComponentById in favor of @ViewChild.

Related: 2295bd9
@adamdbradley adamdbradley self-assigned this Apr 17, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.6 milestone Apr 17, 2016
@Ionitron Ionitron added the menus label Apr 17, 2016
@adamdbradley
Copy link
Contributor Author

Includes id directive too.

@jgw96 jgw96 removed the menus label Apr 19, 2016
@adamdbradley
Copy link
Contributor Author

Yup, use @ViewChild: ionic-team/ionic-conference-app@36ada4b

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamdbradley adamdbradley

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.7
Development

No branches or pull requests
4 participants
@adamdbradley @brandyscarney @Ionitron @jgw96