Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(slides): custom class not being applied #6277

Closed
dylanvdmerwe opened this issue Apr 22, 2016 · 2 comments
Closed

bug(slides): custom class not being applied #6277

dylanvdmerwe opened this issue Apr 22, 2016 · 2 comments

Comments

@dylanvdmerwe
Copy link
Contributor

dylanvdmerwe commented Apr 22, 2016

Short description of the problem:

I have an ion-slides element that I wish to have buttons outside of the element underneath the slider. However the class I have created and set on the ion-slides component is not being applied:

SCSS

    .has-bottom-buttons {
        height: calc(100% - 45px);
    }

HTML

   <ion-slides pager class='has-bottom-buttons' [options]='options'>

Note that this worked in beta 4. If I inspect the HTML, the has-bottom-buttons class is not applied to the element. If I manually add the class, the functionality works as expected.

Custom classes should be applied to ion-slides.

Which Ionic Version? 2.x

Plunker that shows an example of your issue

http://plnkr.co/edit/1Jd0EldWishtLdG0T6qL?p=preview

Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.1.1
Ionic Framework Version: 2.0.0-beta.6
Ionic CLI Version: 2.0.0-beta.24
Ionic App Lib Version: 2.0.0-beta.14
OS:
Node Version: v5.10.1

@dylanvdmerwe dylanvdmerwe changed the title issue(slides): custom class not being applied bug(slides): custom class not being applied Apr 22, 2016
@dylanvdmerwe
Copy link
Contributor Author

Also discussed: #6275

@jgw96
Copy link
Contributor

jgw96 commented Apr 22, 2016

Hey @dylanvdmerwe ! Thanks for opening this issue! So im gonna go ahead and close this as a dupe of #6275 but please feel free to chime in on that issue. Thanks!

@jgw96 jgw96 closed this as completed Apr 22, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants