Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal close not firing lifecycle events #8543

Closed
aggarwalankush opened this issue Oct 6, 2016 · 3 comments
Closed

Modal close not firing lifecycle events #8543

aggarwalankush opened this issue Oct 6, 2016 · 3 comments
Assignees

Comments

@aggarwalankush
Copy link
Contributor

Short description of the problem:

I'm showing a modal from my page. In beta 11, when I close modal, it used to fire ionViewWillEnter/ionViewDidEnter events of parent page but in rc0, it's not.

What behavior are you expecting?

Is it expected behavior?

Steps to reproduce:
Show modal from a page with lifecycle events

Which Ionic Version? 1.x or 2.x
Ionic 2 rc0

Run ionic info from terminal/cmd prompt: (paste output below)

Your system information:

Cordova CLI: 6.3.1
Ionic Framework Version: 2.0.0-rc.0
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
ios-deploy version: 1.9.0
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v6.7.0
Xcode version: Xcode 8.0 Build version 8A218a

@manucorporat manucorporat self-assigned this Oct 6, 2016
@jgw96
Copy link
Contributor

jgw96 commented Oct 7, 2016

Hello, thanks for opening an issue with us! I am going to close this issue as a duplicate of #8414.

@jgw96 jgw96 closed this as completed Oct 7, 2016
@aggarwalankush
Copy link
Contributor Author

@jgw96 seems like in #8414 ionViewDidLoad of Modal page is not called, but in my case, parent page events are not called when modal is closed.

@manucorporat manucorporat reopened this Oct 10, 2016
@manucorporat
Copy link
Contributor

manucorporat commented Oct 12, 2016

Fixed!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants