From 8e8a1f006f74b94dfcd61d1963a69f49693730fd Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 1 Jul 2021 20:57:33 +0000 Subject: [PATCH 1/3] fix inputs --- angular/src/directives/overlays/ion-modal.ts | 4 ++-- angular/src/directives/overlays/ion-popover.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/angular/src/directives/overlays/ion-modal.ts b/angular/src/directives/overlays/ion-modal.ts index 83f6a31606e..203ba92d488 100644 --- a/angular/src/directives/overlays/ion-modal.ts +++ b/angular/src/directives/overlays/ion-modal.ts @@ -5,8 +5,8 @@ import { ProxyCmp, proxyOutputs } from "../proxies-utils"; import { Components } from "@ionic/core"; export declare interface IonModal extends Components.IonModal { } -@ProxyCmp({ inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) -@Component({ selector: "ion-modal", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "component", "componentProps", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent"] }) +@ProxyCmp({ inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) +@Component({ selector: "ion-modal", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) export class IonModal { @ContentChild(TemplateRef, { static: false }) template: TemplateRef; diff --git a/angular/src/directives/overlays/ion-popover.ts b/angular/src/directives/overlays/ion-popover.ts index c5add56ec73..e0d5975d517 100644 --- a/angular/src/directives/overlays/ion-popover.ts +++ b/angular/src/directives/overlays/ion-popover.ts @@ -5,8 +5,8 @@ import { ProxyCmp, proxyOutputs } from "../proxies-utils"; import { Components } from "@ionic/core"; export declare interface IonPopover extends Components.IonPopover { } -@ProxyCmp({ inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) -@Component({ selector: "ion-popover", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "component", "componentProps", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent"] }) +@ProxyCmp({ inputs: ["alignment", "animated", "arrow", "backdropDismiss", "cssClass", "dismissOnSelect", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent", "trigger", "triggerAction", "reference", "size"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) +@Component({ selector: "ion-popover", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["alignment", "animated", "arrow", "backdropDismiss", "cssClass", "dismissOnSelect", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent", "trigger", "triggerAction", "reference", "size"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) export class IonPopover { @ContentChild(TemplateRef, { static: false }) template: TemplateRef; From e0083b7ce319d46f85bf0e3d52bc72e4d631b008 Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 1 Jul 2021 20:59:50 +0000 Subject: [PATCH 2/3] add trigger too --- angular/src/directives/overlays/ion-modal.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/angular/src/directives/overlays/ion-modal.ts b/angular/src/directives/overlays/ion-modal.ts index 203ba92d488..83d433ffb07 100644 --- a/angular/src/directives/overlays/ion-modal.ts +++ b/angular/src/directives/overlays/ion-modal.ts @@ -5,8 +5,8 @@ import { ProxyCmp, proxyOutputs } from "../proxies-utils"; import { Components } from "@ionic/core"; export declare interface IonModal extends Components.IonModal { } -@ProxyCmp({ inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) -@Component({ selector: "ion-modal", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) +@ProxyCmp({ inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent", "trigger"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) +@Component({ selector: "ion-modal", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent", "trigger"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) export class IonModal { @ContentChild(TemplateRef, { static: false }) template: TemplateRef; From 5516a74a9ae7062daef5fc992a45ecdbd19639bd Mon Sep 17 00:00:00 2001 From: Liam DeBeasi Date: Thu, 1 Jul 2021 21:31:29 +0000 Subject: [PATCH 3/3] typo --- angular/src/directives/overlays/ion-modal.ts | 2 +- angular/src/directives/overlays/ion-popover.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/angular/src/directives/overlays/ion-modal.ts b/angular/src/directives/overlays/ion-modal.ts index 83d433ffb07..a2b23878b9d 100644 --- a/angular/src/directives/overlays/ion-modal.ts +++ b/angular/src/directives/overlays/ion-modal.ts @@ -6,7 +6,7 @@ import { Components } from "@ionic/core"; export declare interface IonModal extends Components.IonModal { } @ProxyCmp({ inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent", "trigger"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) -@Component({ selector: "ion-modal", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent", "trigger"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) +@Component({ selector: "ion-modal", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["animated", "backdropDismiss", "cssClass", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "presentingElement", "showBackdrop", "swipeToClose", "translucent", "trigger"] }) export class IonModal { @ContentChild(TemplateRef, { static: false }) template: TemplateRef; diff --git a/angular/src/directives/overlays/ion-popover.ts b/angular/src/directives/overlays/ion-popover.ts index e0d5975d517..e6352ff0760 100644 --- a/angular/src/directives/overlays/ion-popover.ts +++ b/angular/src/directives/overlays/ion-popover.ts @@ -6,7 +6,7 @@ import { Components } from "@ionic/core"; export declare interface IonPopover extends Components.IonPopover { } @ProxyCmp({ inputs: ["alignment", "animated", "arrow", "backdropDismiss", "cssClass", "dismissOnSelect", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent", "trigger", "triggerAction", "reference", "size"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) -@Component({ selector: "ion-popover", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["alignment", "animated", "arrow", "backdropDismiss", "cssClass", "dismissOnSelect", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent", "trigger", "triggerAction", "reference", "size"], "methods": ["present", "dismiss", "onDidDismiss", "onWillDismiss"] }) +@Component({ selector: "ion-popover", changeDetection: ChangeDetectionStrategy.OnPush, template: ``, inputs: ["alignment", "animated", "arrow", "backdropDismiss", "cssClass", "dismissOnSelect", "enterAnimation", "event", "isOpen", "keyboardClose", "leaveAnimation", "mode", "showBackdrop", "translucent", "trigger", "triggerAction", "reference", "size"] }) export class IonPopover { @ContentChild(TemplateRef, { static: false }) template: TemplateRef;