-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/input): update onInput to InputEvent #24111
fix(core/input): update onInput to InputEvent #24111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A few changes:
- Can we sync with the latest
next
? There are some testing changes that I would like for this to run. - Can we see if we can do without the typecasting when emitting
ionInput
?
dcb9103
to
1e04069
Compare
Branch is now rebased against next. Typecasting can be removed in a future task (captured), once the Stencil public runtime types are updated/released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! This is good to merge. When merging can we update the commit message to follow https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#commit-message-guidelines?
1e04069
to
d811907
Compare
The ionInput event for both ion-input and ion-textarea will emit with a type of InputEvent.
d811907
to
dc983a7
Compare
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ionInput
was emitting a value of typeKeyboardEvent
.Issue Number: #24083
What is the new behavior?
ionInput
is now emitting a value of typeInputEvent
.Does this introduce a breaking change?
Other information