From 03e822fae655f4f1282e753c2a90c9d121228adc Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Tue, 4 Jan 2022 23:03:27 -0500 Subject: [PATCH 1/2] fix(popover): allow arrow configuration with controller approach --- core/src/components/popover/popover-interface.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/components/popover/popover-interface.ts b/core/src/components/popover/popover-interface.ts index 3c7b96ad399..e8f796a38e6 100644 --- a/core/src/components/popover/popover-interface.ts +++ b/core/src/components/popover/popover-interface.ts @@ -30,12 +30,13 @@ export interface PopoverOptions { reference?: PositionReference; side?: PositionSide; align?: PositionAlign; + arrow?: boolean; trigger?: string; triggerAction?: string; } -export interface PopoverAttributes extends JSXBase.HTMLAttributes {} +export interface PopoverAttributes extends JSXBase.HTMLAttributes { } export type PopoverSize = 'cover' | 'auto'; From f4d0361b421640638bc46ab5ee5efc1e1a9397e3 Mon Sep 17 00:00:00 2001 From: Sean Perkins Date: Wed, 5 Jan 2022 10:53:47 -0500 Subject: [PATCH 2/2] chore(): update popover docs for props --- core/src/components/popover/readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/components/popover/readme.md b/core/src/components/popover/readme.md index fa6d5ce2db2..7639eba5dbc 100644 --- a/core/src/components/popover/readme.md +++ b/core/src/components/popover/readme.md @@ -108,6 +108,7 @@ interface PopoverOptions { reference?: PositionReference; side?: PositionSide; align?: PositionAlign; + arrow?: boolean; } ```