Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(button): update docs for properties to describe options better #25940

Merged
merged 3 commits into from
Sep 14, 2022
Merged

docs(button): update docs for properties to describe options better #25940

merged 3 commits into from
Sep 14, 2022

Conversation

brandyscarney
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@brandyscarney brandyscarney requested a review from a team as a code owner September 14, 2022 14:14
@github-actions github-actions bot added the package: core @ionic/core package label Sep 14, 2022
@brandyscarney brandyscarney mentioned this pull request Sep 14, 2022
Merged
liamdebeasi
liamdebeasi approved these changes Sep 14, 2022
View reviewed changes
core/src/components/button/button.tsx Outdated Show resolved Hide resolved
@brandyscarney brandyscarney merged commit 0855f8d into main Sep 14, 2022
@brandyscarney brandyscarney deleted the docs-button-prop-updates branch September 14, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averyjohnston averyjohnston averyjohnston approved these changes

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandyscarney @liamdebeasi @averyjohnston