-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(email-composer): Aligned function calls with Cordova plugin #3220
Conversation
What happens with this kind of thing, does it ever get reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit only the changed plugin file, nothing else.
Removed settings file because contained within .vscode that should not be included within the repository
OK I have deleted the settings.json file. Regards |
Hi, could you provide feedback on what has happened with this, it looks like I have failed to do something and you've closed it because of that? However it is very confusing on what exactly I am supposed to do? I assume because the .vscode settings file was committed in error that has caused the problem, I did delete that file change and thought that was adequate, what did I miss? |
You still committed the package-lock changes so I committed your changes by my self. |
ah OK sorry my apologies!
…On Tue, Nov 26, 2019 at 6:23 PM Daniel Sogl ***@***.***> wrote:
You still committed the package-lock changes so I committed your changes
by my self.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3220>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMTGYGS5H4UZRYB4CBVPB6TQVVSTJANCNFSM4JH336RQ>
.
|
This is my first attempt at contributing, I have read the guidelines and attempted to follow things as accurately as I can but any feedback to help me in the future is greatly received.
I have been having some major issues with the
cordova-plugin-email-composer
plugin and after no useful feedback on Stackoverflow, Ionic Forum or Github I decided to delve in and see if I could remedy things myself.I have added the missing functions inline with the existing
cordova-plugin-email-composer
documentation, specificallyhasAccount
,hasClient
andgetClients
. I also modified the existingisAvailable
function to maintain compatibility by combining thehasAccount
andhasClient
functions into a single function call for convenience.Apologies for the
.vscode/settings.json
file making an appearance in the changed files list.