Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal, popover): overlays now automatically determine if they are inline #23434

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

liamdebeasi
Copy link
Contributor

… being used inline or not

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Previously you needed to explicitly tell modal/popover that they were not being used inline which caused some breaking changes.

What is the new behavior?

  • We can now automatically detect if the overlay is in the correct location (I.e. a direct descendant of ion-app or body) before presenting, and return the correct delegate based on that.

If overlay is in correct location, we just call present. Otherwise, we pass in either the value of this.delegate or the default core delegate.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jun 8, 2021
@liamdebeasi liamdebeasi merged commit 8dbe8ba into next Jun 8, 2021
@liamdebeasi liamdebeasi deleted the inline-detect branch June 8, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant