Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vue): extend useIonRouter hook for programmatic navigation with animation control #23499

Merged
merged 7 commits into from
Jun 28, 2021
Merged

feat(vue): extend useIonRouter hook for programmatic navigation with animation control #23499

merged 7 commits into from
Jun 28, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 23, 2021 •
edited
Loading

Docs update: ionic-team/ionic-docs#1989

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23450

What is the new behavior?

  • Added push, replace, back, forward, and navigate methods

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: vue @ionic/vue package label Jun 23, 2021
@liamdebeasi liamdebeasi marked this pull request as ready for review June 28, 2021 13:05
@liamdebeasi liamdebeasi mentioned this pull request Jun 28, 2021
Merged
@liamdebeasi liamdebeasi merged commit fc9e1b4 into next Jun 28, 2021
@liamdebeasi liamdebeasi deleted the vue-router-nav branch June 28, 2021 14:33
@liamdebeasi liamdebeasi mentioned this pull request Jun 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liamdebeasi