Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input, select, textarea): change type of placeholder prop to string only #23500

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Jun 23, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22976

What is the new behavior?

  • Updated the placeholder property on ion-input, ion-textarea, and ion-select to have a type of string | undefined.

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions bot added the package: core @ionic/core package label Jun 23, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we update the BREAKING.md document with this since it's a change to the public API. You can probably add breaking change notes for ion-input and ion-textarea each similar to what we did for ion-modal and ion-popover.

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! When you create the merge commit, be sure to add a "BREAKING CHANGE" line so it shows up in the changelog.

Example:

resolves #22976

BREAKING CHANGE: Updated the `placeholder` property on `ion-input`, `ion-textarea`, and `ion-select` to have a type of `string | undefined`.

@willmartian willmartian merged commit f3ae431 into next Jun 24, 2021
@willmartian willmartian deleted the fix/22976 branch June 24, 2021 14:23
@willmartian willmartian linked an issue Jun 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: placeholder types not compliant in ionic / react
2 participants