Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: popover size is not working properly with an event (no trigger) #23528

Closed
brandyscarney opened this issue Jun 28, 2021 · 2 comments
Closed
Assignees
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@brandyscarney
Copy link
Member

Bug Report

Ionic version:

[ ] 4.x
[ ] 5.x
[x] 6.x

Current behavior:

Passing size: 'cover' when opening a popover using a popoverController is not working with an event without a trigger, the trigger is null

Expected behavior:

The popover should be using the element from the passed in event here:
https://github.com/ionic-team/ionic-framework/blob/next/core/src/components/popover/animations/ios.enter.ts#L22
https://github.com/ionic-team/ionic-framework/blob/next/core/src/components/popover/animations/md.enter.ts#L21

Steps to reproduce:

Can be reproduced on the next branch by passing size: cover with an event

@liamdebeasi
Copy link
Contributor

Resolved via #23532.

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 29, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants