-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change Datetime Start of the Week #23556
Comments
What would be the preferred implementation here? @liamdebeasi I guess a Property as it looks like there is no pure js implementation without creating a map for every locale |
Yup, our users keep picking the wrong day because they visually pick the first date in the row assuming it is Monday, when in fact it is Sunday in this date picker. |
I can create a PR, i just don't know what the Ionic Team's preferred Solution is. Creating a Prop would be the easiest one, but it removes the configuration by locale advantage. But it doesn't look like there is an pure js solutions, so i think the options are:
|
I would prefer a For example, The definition should look something like this: @Prop() startOfWeek: number = 0; It might be worth doing some investigating first to see if we can determine the start of the week automatically. We use this API internally: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat. |
I found this open Issue so looks like it's not able to determinate automatically currently: tc39/ecma402#6 I will create a PR with a new Property 😊 |
resolves #23556 Co-authored-by: Liam DeBeasi <[email protected]>
Thanks for the issue. This has been resolved via #23692, and this feature will be available in an upcoming release of the Ionic Framework v6 beta. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Feature Request
Ionic version:
[ ] 4.x
[ ] 5.x
[X] 6.x
Describe the Feature Request
For me living in Germany it would be great to be able to change the Start of the Week day as it is Monday for us.
Describe Solutions
startOfTheWeek
PropertyThe text was updated successfully, but these errors were encountered: