Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(): remove shims for legacy browsers no longer supported in v6 #23592

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jul 8, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Framework v5 enabled support for certain shims for legacy browsers, but these legacy browsers are no longer supported in Framework v6 so the shims are not needed.

What is the new behavior?

  • Undoes part of chore(build): set stencil extras config #21877
  • Removed shims for css variables, safari 10, and shadow dom
  • Apps should get a very minor perf bump since the JS checks for whether or not to load the shims are no longer present.

Note: dynamicImportShim is still required because we support Firefox 63+ in v6, but dynamic imports were not added until Firefox 67.

Does this introduce a breaking change?

  • [y] Yes
  • No

Note: This is technically a breaking change, but we have already noted this change in https://github.com/ionic-team/ionic-framework/blob/next/BREAKING.md#browser-and-platform-support so as long as developers are running the supported browser and platform versions this change should be invisible to them.

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jul 8, 2021
@liamdebeasi liamdebeasi merged commit 259b135 into next Jul 8, 2021
@liamdebeasi liamdebeasi deleted the perf-shim branch July 8, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant