Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breadcrumbs): ionCollapsedClick event payload now contains references to collapsed breadcrumb elements #23611

Merged
merged 3 commits into from
Jul 13, 2021
Merged

feat(breadcrumbs): ionCollapsedClick event payload now contains references to collapsed breadcrumb elements #23611

merged 3 commits into from
Jul 13, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23552

What is the new behavior?

  • The ionCollapsedClick event payload now contains the collapsedBreadcrumbs key whose value is an array of collapsed ion-breadcrumb elements.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jul 12, 2021
willmartian
willmartian approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@liamdebeasi liamdebeasi merged commit 9ce57d2 into next Jul 13, 2021
@liamdebeasi liamdebeasi deleted the breadcrumbs-info branch July 13, 2021 15:21
@liamdebeasi liamdebeasi mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmartian willmartian willmartian approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @willmartian