Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: datetime current day on ios should not use text color var #23723

Closed
4 of 6 tasks
milanharia opened this issue Aug 4, 2021 · 4 comments
Closed
4 of 6 tasks

bug: datetime current day on ios should not use text color var #23723

milanharia opened this issue Aug 4, 2021 · 4 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@milanharia
Copy link

Prequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

When using the IonDatetime component, when the current day is selected, the text color takes the same color as defined by --ion-text-color in variables.css. This causes contrast issues as seen in the attached screenshot. This only happens in iOS, the md variation of the component works fine.

I currently have --ion-text-color defined in :root as #6A6A6A which makes the selected current day inherit that color instead of displaying as white.

localhost_8100_home(iPhone X)

Expected Behavior

I expect the color of the selected current day to display as white as it does in the md variation of the component (see below),

localhost_8100_home(Pixel 2 XL)

Steps to Reproduce

I am using the current code to render the home component:

<IonPage>
    <IonHeader>
      <IonToolbar>
        <IonTitle>Home</IonTitle>
      </IonToolbar>
    </IonHeader>
    <IonContent fullscreen className='ion-padding'>
      <IonDatetime display-timezone='utc' presentation='date'>
        <div slot='title'>TITLE</div>
      </IonDatetime>
    </IonContent>
  </IonPage>

In variables.css:

:root { --ion-text-color: #6a6a6a; }

Code Reproduction URL

No response

Ionic Info

Ionic:

Ionic CLI : 6.16.3 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 6.0.0-beta.2

Capacitor:

Capacitor CLI : 3.1.2
@capacitor/android : not installed
@capacitor/core : 3.1.2
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 1.4.0

System:

NodeJS : v14.15.1 (/usr/local/bin/node)
npm : 6.14.8
OS : macOS Big Sur

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Aug 4, 2021
@liamdebeasi liamdebeasi changed the title bug: Ion Datetime current day text color not changing bug: datetime current day on ios should not use text color var Aug 4, 2021
@liamdebeasi liamdebeasi added help wanted a good issue for the community type: bug a confirmed bug report labels Aug 4, 2021
@ionitron-bot ionitron-bot bot removed the triage label Aug 4, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package triage and removed help wanted a good issue for the community labels Aug 4, 2021
@ionic-team ionic-team deleted a comment from ionitron-bot bot Aug 4, 2021
@ionitron-bot ionitron-bot bot removed the triage label Aug 4, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm install @ionic/[email protected] @ionic/[email protected]

@milanharia
Copy link
Author

It works fine in the dev build. Thank you for the quick response!

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #23729, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants