Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ionChange does not fire on ion-accordion-group in vue #23762

Closed
4 of 6 tasks
liamdebeasi opened this issue Aug 11, 2021 · 2 comments
Closed
4 of 6 tasks

bug: ionChange does not fire on ion-accordion-group in vue #23762

liamdebeasi opened this issue Aug 11, 2021 · 2 comments
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Milestone

Comments

@liamdebeasi
Copy link
Contributor

Prequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

ionChange does not fire on ion-accordion-group because the internal component is firing v-ion-change. In https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/ionic-vue.ts#L12-L13 we assume that every component that fires ionChange is a v-model component. That was true in v5, but in v6 we added accordion which is not a v-model component.

Expected Behavior

I would expect ionChange to fire on ion-accordion-group

Steps to Reproduce

Add @ionChange to ion-accordion-group and observe that callback does not fire

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

No response

@ionitron-bot ionitron-bot bot added the triage label Aug 11, 2021
@liamdebeasi liamdebeasi added package: vue @ionic/vue package type: bug a confirmed bug report and removed triage labels Aug 11, 2021
@liamdebeasi liamdebeasi added this to the 6.0.0-rc.1 milestone Oct 7, 2021
@liamdebeasi
Copy link
Contributor Author

Resolved via #24063.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 12, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: vue @ionic/vue package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

1 participant