Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reorder-group): wait for content to render before getting scroll position #24007

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

willmartian
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23875

What is the new behavior?

  • Dragging a reorderable element now properly scrolls ion-content

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 4, 2021
@liamdebeasi
Copy link
Contributor

Can you make a dev build so I can test this in an app using custom elements build?

@willmartian
Copy link
Contributor Author

Can you make a dev build so I can test this in an app using custom elements build?

@liamdebeasi, created dev build 6.0.0-dev.202110041416.8e2ffd7

I also tested this in the original repository submitted by the issue creator and it resolved the issue: https://github.com/tetsuwanadam/ionic_reorder_scroll

@willmartian willmartian merged commit 225a278 into next Oct 5, 2021
@liamdebeasi liamdebeasi deleted the FW-176 branch March 24, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants