Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): fix backdrop animation for sheets with off-center backdropBreakpoint #24061

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

averyjohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: Resolves part of #23923

The backdrop animation is incorrect when dragging a sheet modal with a backdropBreakpoint that isn't 0, 1, or 0.5. (See recordings)

What is the new behavior?

Backdrop now animates as expected.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sheet modal shown below with { backdropBreakpoint: 0.3, initialBreakpoint: 0.3, breakpoints: [0.3, 0.5, 0.7, 1] }.

Before: https://user-images.githubusercontent.com/90629384/136992903-c32b63b5-24c3-43c6-b51c-727c68a22ae1.mp4
After: https://user-images.githubusercontent.com/90629384/136991453-48e3832f-90f6-4899-a4ba-1fc3c0c4527b.mp4

@github-actions github-actions bot added the package: core @ionic/core package label Oct 12, 2021
@averyjohnston averyjohnston merged commit 49db6d0 into next Oct 12, 2021
@averyjohnston averyjohnston deleted the FW-212 branch October 12, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant