Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion-group): ionChange is now fired properly #24063

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23762

What is the new behavior?

  • Ion-accordion-group now fires the correct ionChange event and the IonicVue plugin now converts it properly

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Oct 12, 2021
@liamdebeasi liamdebeasi merged commit 61b99d1 into next Oct 13, 2021
@liamdebeasi liamdebeasi deleted the FW-131 branch October 13, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant