fix(accordion): improve functionality with nested accordions #24302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number see internal ticket and https://twitter.com/schlimmson/status/1466015536253480960
The global accordion styles are too general and result in nested accordion groups getting impacts by the state of a parent accordion group. For example, if a parent accordion group is expanded, the icons in a nested accordion group will all be in the expanded state, even if the accordions themselves are not expanded
There was also an issue with keyboard navigation where you could jump between accordion groups by pressing the arrow keys.
What is the new behavior?
:scope
so it was causing errors when the new query selector got run.Does this introduce a breaking change?
Other information