Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of ClientCapabilities for different editors #1032

Open
TheAngryByrd opened this issue Oct 21, 2022 · 2 comments
Open

Better handling of ClientCapabilities for different editors #1032

TheAngryByrd opened this issue Oct 21, 2022 · 2 comments

Comments

@TheAngryByrd
Copy link
Member

After troubleshooting some other LSP Clients (namely emacs and helix) on the Discord server, FSAC will eventually crash. It seems these clients have trouble with the fsharp/ specific notifications that come from FSAC. Fsharp language server put in some fixes regarding this type of behavior too. I'm unsure what exactly the best path of action is here.

  1. Put a flag in so we know we're talking to Ionide, otherwise just no-op the fsharp/ calls. (quick)
  2. Better handling at the LSP Client level at parsing bad information from standard in (unsure how much work is related here)
  3. Make other clients not send stuff to standard in when they receive notifications they can't handle (given 2 separate editors seem to have this behavior, I'm unsure if they're at fault here).
@baronfel
Copy link
Contributor

We already keep the clientCapabilities locally - we should look at the info that we get on the initialize request that describe the client, and for these clients that don't support the custom notifications set a flag that enables/disables those notifications.

@TheAngryByrd
Copy link
Member Author

Sounds like a plan

@TheAngryByrd TheAngryByrd changed the title Hide Ionide specific notifications LSP endpoints behind a flag Better handling of ClientCapabilities for different editors Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants