Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guide for plugins #1090

Open
larsbuntemeyer opened this issue Jun 6, 2024 · 3 comments
Open

contribution guide for plugins #1090

larsbuntemeyer opened this issue Jun 6, 2024 · 3 comments

Comments

@larsbuntemeyer
Copy link

Hi everybody,
i am using compliance-checker to check CF conventions of my model output for the CORDEX-CMIP6 MIP. We are also implementing some more CORDEX and CORDEX CV specific checks and i was evaluating if this could become a plugin for the compliance-checker since it offers a very nice framework and reporting capabilities. However, I am not sure how to start. I am not sure, if the plugin system was meant to be used also by external contributors. I was starting to dig through the code, e.g., of the ioos/cc-plugin-glider, but it's hard to get a grasp on it. It seems that i should start probably to inherit from BaseNCCheck and define an entry point, e.g., like here?

https://github.com/ioos/cc-plugin-glider/blob/24c3cfd70c69c97a720f74bc74f8a642c02b616d/pyproject.toml#L34

Thanks a lot!

@ocefpaf
Copy link
Member

ocefpaf commented Jun 6, 2024

I am not sure, if the plugin system was meant to be used also by external contributors.

It was designed for that use case.

I should start probably to inherit from BaseNCCheck and define an entry point, e.g., like here?

Maybe this one is a better starting point for you. It is a bit simpler and newer than the glider one.

@larsbuntemeyer
Copy link
Author

Thanks, nice example, that's making it much easier to start!

@ocefpaf
Copy link
Member

ocefpaf commented Jun 6, 2024

I cannot take merit for it. @jcermauwedu is the one that created this nice plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants