Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify custom encoder for Tendermint RPC? #1361

Open
KrishnaPG opened this issue Jan 3, 2020 · 1 comment
Open

How to specify custom encoder for Tendermint RPC? #1361

KrishnaPG opened this issue Jan 3, 2020 · 1 comment

Comments

@KrishnaPG
Copy link

Currently the methods, such as broadcastTx etc. are hardcoded to use base64 encoding in the rpc package.

tx: Base64.encode(assertNotEmpty(params.tx)),

It would be good to let the encoding to be specified by the caller (defaulting to base64 if none specified). For example, when passing a string directly as the tx param, the base64 is throwing error (obviously). Since the Tendermint itself does not have any restriction on the encoding of Tx params, allowing the user to decide the best encoding would be very helpful.

@willclarktech
Copy link
Contributor

Hi @KrishnaPG, thanks for the suggestion. We'll consider it when we have more developer capacity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants