Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root package.json scripts should also apply to root dir #829

Open
2 tasks
willclarktech opened this issue Mar 7, 2019 · 4 comments
Open
2 tasks

Root package.json scripts should also apply to root dir #829

willclarktech opened this issue Mar 7, 2019 · 4 comments

Comments

@willclarktech
Copy link
Contributor

  • lint
  • format
@webmaster128
Copy link
Contributor

webmaster128 commented Mar 18, 2019

What is there to be linted/formatted in the repo root? Both steps are done for *.ts files only

@willclarktech
Copy link
Contributor Author

I guess linting's not an issue, but Prettier can make sure code blocks in .md files are formatted nicely. (And less importantly .json files).

@webmaster128
Copy link
Contributor

Now that lint-fix can take care of our source code, we can use yarn format for formatting configs. So I propose the following path:

  1. Create lint-fix scripts in all packages and root (see ponferrada) for manual execution
  2. Remove yarn format, as this is covered by yarn lint/yarn lint-fix
  3. Create new format script that formats configs .json / .yml and does not run on files that are covered by eslint. (This one I'm not exactly sure about. Is there a good reason to keep jsom/yml/md out of the default prettier+autofixer setup?)

@willclarktech
Copy link
Contributor Author

Is there a good reason to keep jsom/yml/md out of the default prettier+autofixer setup?

Best I can think of is that the prettier formatters for these kinds of files seem to be a bit more bug-prone than for .js/.ts, but I don't think that's a good enough reason not to include them by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants