Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Jest #953

Closed
1 of 2 tasks
webmaster128 opened this issue Apr 30, 2019 · 7 comments
Closed
1 of 2 tasks

Migrate to Jest #953

webmaster128 opened this issue Apr 30, 2019 · 7 comments

Comments

@webmaster128
Copy link
Contributor

webmaster128 commented Apr 30, 2019

I tried conversion package-by-package before but unfortunately, the testing types from @types/jasmine (like describe or it) are monorepo global. So this is an all or nothing task.

Looks like Jest uses most of the same expect syntax, so Jasmine -> Jest should be easier than Jasmine -> Mocha.

  • Migrate from jasmine2-custom-message to Jasmine native withContext (e.g. here). Not beatiful but we rarely need it and can get rid of one dependency
  • Migrate Jasmine -> Jest
@willclarktech
Copy link
Contributor

Task 1 completed: #954

@webmaster128
Copy link
Contributor Author

#954 now backported to branch 0.13 and 0.14

@webmaster128
Copy link
Contributor Author

I stared with this but found a serious limitation: if I understand correctly, jest requires a nodeJS environment and cannot be run in a real browser. This is very unfortunate, since we want to ensure that the real browser's JS engines support our code.

@karol-depka
Copy link

I stared with this but found a serious limitation: if I understand correctly, jest requires a nodeJS environment and cannot be run in a real browser. This is very unfortunate, since we want to ensure that the real browser's JS engines support our code.

Hey. Is this for sure? I'm considering migration to Jest for a number of projects too...

@webmaster128
Copy link
Contributor Author

Hi @karol-depka, I jave a few strong indications:

@karol-depka
Copy link

@webmaster128 Thank You very much for taking the time to explain all this! Much appreciated and a great gesture! Cheers!

@webmaster128
Copy link
Contributor Author

Closing this for the reasons described above. We'll not migrate to Jest for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants