Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test push / fetch #7

Merged
merged 1 commit into from
Mar 17, 2018
Merged

Test push / fetch #7

merged 1 commit into from
Mar 17, 2018

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 16, 2018

No description provided.

magik6k
magik6k approved these changes Mar 17, 2018
View reviewed changes
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've spotted some nitpick-level stuff, though I'll be soon refactoring large part of the project anyways so it doesn't really matter for now.

@magik6k magik6k merged commit 1b33d35 into ipfs-shipyard:master Mar 17, 2018
@dirkmc
Copy link
Contributor Author

dirkmc commented Mar 17, 2018

No worries, happy to fix any nits
What are you working on next? I was thinking of looking at the IPNS part

@magik6k
Copy link
Collaborator

magik6k commented Mar 18, 2018

I want to get coreapi in go-ipfs(-api) to a workable state first so I won't have to rewrite this as much. The tracking issue is ipfs/kubo#4498, go-ipfs-api pr here: ipfs/go-ipfs-api#76. After that is done the ipns helper and the other git work can take off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmc @magik6k