Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish debug docker image #9

Open
olizilla opened this issue Sep 9, 2020 · 7 comments
Open

Publish debug docker image #9

olizilla opened this issue Sep 9, 2020 · 7 comments
Assignees

Comments

@olizilla
Copy link
Member

olizilla commented Sep 9, 2020

as suggested by @hsanjuan , add set -x to the pin-to-cluster.sh script and publish as a docker image tagged asdebug. CI configs can then selectively switch to it by updating the docker image tag.

@olizilla olizilla self-assigned this Sep 9, 2020
@hsanjuan
Copy link
Contributor

hsanjuan commented Sep 9, 2020

@olizilla can we add --debug to ipfs-cluster-ctl as well : ipfs-cluster-ctl --debug...

@hsanjuan
Copy link
Contributor

hsanjuan commented Sep 9, 2020

Did it myself

@olizilla
Copy link
Member Author

olizilla commented Sep 9, 2020

Does --debug changes the output of ipfs-cluster-ctl in the happy path? If it does then it can't be used in CI workflows that expect the output of pin-to-cluster.sh to be just the CID that is then used for dnslink updating.

@thattommyhall
Copy link
Member

Is it worth echo-ing the result of ipfs-cluster-ctl status $root_cid" to stderr too?

@olizilla
Copy link
Member Author

olizilla commented Sep 9, 2020

@thattommyhall my mental model of bash, sub-shells and output streams is not good; can pin-to-cluster.sh log to stderr without disrupting the assumption that the result will be just the cid if called sub-shell style"

cid=$(pin_to_cluster.sh args go here)

@hsanjuan
Copy link
Contributor

@olizilla I think this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants