Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies not listed in package.json: pico #870

Closed
vasco-santos opened this issue Aug 11, 2021 · 0 comments
Closed

Dependencies not listed in package.json: pico #870

vasco-santos opened this issue Aug 11, 2021 · 0 comments

Comments

@vasco-santos
Copy link
Member

Describe the bug
The dependency check test is failing when passed files exist that do not require the dependency in question. Errors with:

1) dependency check
       should pass for passed files:
     AssertionError: expected promise to be fulfilled but it was rejected with 'Error: Command failed with exit code 1: /Users/vsantos/gh/tmp/aegir/cli.js dependency-check derp/foo.js\n- Checking dependencies\n✖ Checking dependencies\nCommand failed with exit code 1: dependency-check package.json .aegir.js .aegir.cjs src/**/*.js src/**/*.cjs test/**/*.js test/**/*.cjs benchmarks/**/*.js benchmarks/**/*.cjs utils/**/*.js utils/**/*.cjs !./test/fixtures/**/*.js !./test/fixtures/**/*.cjs derp/foo.js --missing -i @types/* -i @types/*\nFail! Dependencies not listed in package.json: pico'


  2) dependency check
       should pass for passed production files:
     AssertionError: expected promise to be fulfilled but it was rejected with 'Error: Command failed with exit code 1: /Users/vsantos/gh/tmp/aegir/cli.js dependency-check derp/foo.js -p\n- Checking dependencies\n✖ Checking dependencies\nCommand failed with exit code 1: dependency-check package.json .aegir.js .aegir.cjs src/**/*.js src/**/*.cjs test/**/*.js test/**/*.cjs benchmarks/**/*.js benchmarks/**/*.cjs utils/**/*.js utils/**/*.cjs !./test/fixtures/**/*.js !./test/fixtures/**/*.cjs derp/foo.js --missing --no-dev -i @types/* -i @types/*\nFail! Dependencies not listed in package.json: pico'

To Reproduce
Steps to reproduce the behavior:

  1. Run tests locally
@lidel lidel changed the title Dependency check tests failing for passed files Dependencies not listed in package.json: pico Apr 8, 2022
@lidel lidel closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants