Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS signing keys expire on Jan 23th #1061

Closed
4 of 7 tasks
lidel opened this issue Jan 4, 2024 · 3 comments
Closed
4 of 7 tasks

macOS signing keys expire on Jan 23th #1061

lidel opened this issue Jan 4, 2024 · 3 comments
Assignees

Comments

@lidel
Copy link
Member

lidel commented Jan 4, 2024

  • get new keys/certs (.p12)
    • Plan A: try getting new cert using the old setup
    • Plan B: ipshipyard account setup, including 1password
    • Apple: create ipshipyard org + keys (for both signing AND notarization)
  • switch to new keys in https://github.com/ipfs/distributions
  • switch to new keys in https://github.com/ipfs/ipfs-desktop/
  • check if macOS will error on binary signed with expired key, and if so, cut a path release signed with new key
@lidel lidel converted this from a draft issue Jan 4, 2024
@lidel lidel changed the title Apple macOS Sigbning Keys expire on 27th - we need to set up new ones macOS signing keys expire on 27th Jan 4, 2024
@lidel lidel changed the title macOS signing keys expire on 27th macOS signing keys expire on Jan 27th Jan 4, 2024
@lidel lidel self-assigned this Jan 4, 2024
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Jan 16, 2024
@lidel lidel moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Jan 18, 2024
@lidel lidel changed the title macOS signing keys expire on Jan 27th macOS signing keys expire on Jan 23th Jan 18, 2024
@lidel
Copy link
Member Author

lidel commented Jan 18, 2024

Reached out to PL to see if we can get new cert using old setup,
might be faster than creating new org for Shipyard.

Caveat is that only "Account Holder" can generate cert for publishing outside of proprietary Apple Store:

2024-01-18_22-11

@lidel
Copy link
Member Author

lidel commented Jan 19, 2024

Confirmed signing with new cert works in ipfs/ipfs-desktop#2735 (comment).
Will now do a smoke-test release of ipfs-desktop which has additional step of Notarization after Signing.
Notarization uses different credentials, which afaik do not expire, but let's make sure things work ok together end-to-end.

Will do IPFS Desktop release on Monday (we don't ship things on Friday).

@lidel
Copy link
Member Author

lidel commented Jan 22, 2024

Kubo v0.26 and IPFS Desktop v0.33 both got signed and Notarized correctly.

New certs for signing are valid until 2027 – closing this one.

IP Shipyard will switch to new Apple Dev Org later this year, but no longer a P0 priority.

@lidel lidel closed this as completed Jan 22, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant