-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute repo migrations as set of binaries #326
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
This seems like a reasonable plan. In order to support it we'd need to add some syntax into the scripts for creating/adding binaries that live inside of folders. WDYT @Stebalien @olizilla @hsanjuan Note: If we wanted to we could make this easier by putting the binaries like This is related to ipfs/fs-repo-migrations#98 |
Sounds good. I am mildy in favour of hiding the many migrations under it's own directory. |
@aschmahmann @olizilla Is this something either of you is able to follow up on? Afraid the GUI team is a bit slammed at the moment. |
@jessicaschilling I suspect we'd hide all the GUI changes for now and just change the behind-the-scenes things first (i.e. add the data to dist, but not expose it on the home page). We can then circle back to the UI side of this later |
In the interest of not making a one-off distribution that contains all the individual migrations, another option is to make a new distribution for each migration, but without adding it to the web GUI. @aschmahmann @olizilla Does this approach seem better? Would this allow us to only have to publish the latest migration with each release that needs one? |
After experimenting with organizing the individual migrations under their own distribution root directory, or keeping them each as individual distributions at the top level of distributions, the later seemed like a better choice for now. The reason for this is:
|
Each migration is an individual distribution that is not displayed on the web page of the distributions site. For example: https://dist.ipfs.io/fs-repo-10-to-11. ipfs-update, fs-repo-migrations, and go-ipfs know how to download necessary migration binaries from the new distributions. All work on this issue is completed and deployed. Closing issue. |
Currently, there is a single monolithic binary responsible for all repo migrations, growing with each release that needs repo migration. This will no longer be the case going forward. Repo migrations will be available as a set of smaller binaries, one for each version migration (e.g.
ipfs-9-to-10
,ipfs-10-to-11
). These will be downloaded and run individually bygo-ipfs
,ipfs-update
, andfs-repo-migration
. To facilitate this, some changes to dist.ipfs.io are needed.Directory structure changes
The plan is to store the store the migrations under a common root,
dist.ipfs.io/go-ipfs-repo-migrations/
:The URL to retrieve a 10-to-11 migration for darwin is https://ipfs.io/ipns/dist.ipfs.io/go-ipfs-repo-migrations/ipfs-10-to-11/v1.8.0/ipfs-10-to-11_v1.8.0_linux-amd64.tar.gz
Website changes
There should not be any visible changes to the dist.ipfs.io web pages, since the current plan is to not show the users any links to individual migration binaries. New versions of
fs-repo-migrations
will continue to be available on the dist site, and will know how/where to download the necessary migration binary archives, unpack and install them. There will not be a need for users to download individual migration binaries themselves.Should it be necessary to download a specific migration binary, a URL like the example above could be used. If there ever is a need for users to do this, then a link from the main page to the top-level
go-ipfs-repo-migrations
could be added, but this does not appear to be needed for now.The text was updated successfully, but these errors were encountered: