Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use "go install" for latest release of fs-repo-migrations binary #147

Open
aschmahmann opened this issue Jan 10, 2022 · 3 comments
Open
Labels
need/triage Needs initial labeling and prioritization

Comments

@aschmahmann
Copy link
Contributor

aschmahmann commented Jan 10, 2022

As a result of the move to submodules go install github.com/ipfs/fs-repo-migrations will target v1.7.1 since it was the last binary version to be present in that module. The fs-repo-migrations binary is now in a fs-repo-migrations subfolder+module. This means it needs to be installed as go install github.com/ipfs/fs-repo-migrations/fs-repo-migrations.

Unfortunately, there's not currently a tag for fs-repo-migrations/v2.0.2 so it will just pull the latest commit.

We should either:

  1. Move fs-repo-migrations back to the root module and retag the root (e.g. v2.0.3)
  2. Tag fs-repo-migrations/v2.0.3

Whichever we do should be documented in the README

@aschmahmann aschmahmann added the need/triage Needs initial labeling and prioritization label Jan 10, 2022
@BigLep
Copy link
Contributor

BigLep commented Mar 10, 2022

@aschmahmann : is there a preferred approach or are both equal? Any concern with giving this to @schomatis ?

@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
@GwynethLlewelyn
Copy link

Speaking strictly for myself, I'd prefer a new tag, but I'm also fine with a comment in the README telling the user to run go install github.com/ipfs/fs-repo-migrations/fs-repo-migrations instead. So long as one doesn't need to wade eternally through the issues to figure out how to do it... 😸

@lanceseidman
Copy link

Need to run "go install github.com/ipfs/fs-repo-migrations/fs-repo-migrations@latest".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: 🥞 Todo
Development

No branches or pull requests

4 participants