Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--unrestricted-api #3058

Closed
daviddias opened this issue Aug 8, 2016 · 5 comments
Closed

--unrestricted-api #3058

daviddias opened this issue Aug 8, 2016 · 5 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/api Topic api topic/CORS Issues related to CORS on HTTP endpoints topic/rpc-api Issues related to Kubo RPC API at /api/v0

Comments

@daviddias
Copy link
Member

Now, CORS also requests the "Access-Control-Allow-Credentials" to be set to true.

Can we have the --unrestricted-api to add that flag as well? The full list is:

      "Access-Control-Allow-Origin": [
        "http://localhost:5001",
        "http://localhost:8888"
      ],
      "Access-Control-Allow-Methods": [
        "PUT",
        "GET",
        "POST"
      ],
      "Access-Control-Allow-Credentials": [
        "true"
      ]

//cc @whyrusleeping

@daviddias daviddias added kind/enhancement A net-new feature or improvement to an existing feature topic/api Topic api labels Aug 8, 2016
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 8, 2016
@whyrusleeping
Copy link
Member

I think that makes sense to do. That flag should really mean "let me do whatever i want with the API now"

@jbenet
Copy link
Member

jbenet commented Aug 10, 2016

It probably should say --insecure-api to be super clear.

ipfs daemon --president-madagascar=false
On Tue, Aug 9, 2016 at 12:09 Jeromy Johnson [email protected]
wrote:

I think that makes sense to do. That flag should really mean "let me do
whatever i want with the API now"


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3058 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIcoYZA-t4aZq3LvmeFC-0FhwKOSdCUks5qeKY2gaJpZM4Je981
.

@whyrusleeping
Copy link
Member

ipfs daemon --world-domination=true --do-that-one-thing-with-the-giraffe=false --redisenable-discombobulated-inhibitors

Yeah, lets make things do what they say

@travisperson
Copy link
Member

ipfs --i-know-what-im-doing because if you have to ask what it does, you probably shouldn't be using it.

@magik6k
Copy link
Member

magik6k commented May 15, 2019

I'd like to avoid adding new flags to the daemon, but if this can be set through config, we may just add a config profile for this.

@daviddias daviddias added the topic/rpc-api Issues related to Kubo RPC API at /api/v0 label Oct 8, 2019
@lidel lidel added the topic/CORS Issues related to CORS on HTTP endpoints label Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/api Topic api topic/CORS Issues related to CORS on HTTP endpoints topic/rpc-api Issues related to Kubo RPC API at /api/v0
Projects
None yet
Development

No branches or pull requests

6 participants