Correctly set the content type for object get --encoding=protobuf
#2516
Conversation
Stebalien
force-pushed
the
protobuf-content-type
branch
2 times, most recently
from
d6cc942
to
becd679
Compare
|
Unfortunately, I have no idea why my test cases are failing. They when I run them manually. |
| ' | ||
|
|
||
| test_expect_success "'ipfs object get --encoding=json' returns the correct content type" ' | ||
| HASH="QmWkHFpYBZ9mpPRreRbMhhYWXfUhBAue3JkbbpFqwowSRb" && |
There was a problem hiding this comment.
You don't need to re-set the HASH variable in each scope. shell variables like this are global(ish)
There was a problem hiding this comment.
That's what I did the first time around but it still failed.
Steven Allen
Stebalien
force-pushed
the
protobuf-content-type
branch
2 times, most recently
from
8b2a8b4
to
2e9d36a
Compare
I didn't realize those tests were run offline as well... |
|
I'm pretty sure the other failing tests are not my fault. |
|
Also subscribing. |
It used to default to `application/json` but is now correctly set to `application/protobuf`. fixes ipfs#2469 License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
protobuf-content-type
branch
from
2e9d36a
to
a72d26b
Compare
|
@noffle i assigned another related PR to you, so i'm gonna assign this one as well |
|
LGTM, the change looks much bigger than it is because golang indenting changes but it is really very small change. |
|
LGTM, great to finally have this merged in |
|
Does this only apply to |
|
@RichardLitt Yes. Are there any other endpoints that return protocol buffers? |
|
@Stebalien Looked again; not that I could see. Sweet. |
It used to default to
application/jsonbut is now correctly set toapplication/protobuf.fixes #2469
License: MIT
Signed-off-by: Steven Allen [email protected]