commands/cli: fix reading from stdin message #3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test_expect_code 1 grep "ipfs: Reading from" add_help_out && | ||
| test_expect_code 1 grep "send Ctrl-d to stop." add_help_out | ||
| ' | ||
|
|
There was a problem hiding this comment.
This test would be successful even before the patch, you have to capture both stdout and stderr.
Only print "Reading from /dev/stdin" message when we actually read from stdin (and not in other cases such as ipfs add --help). License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/stdin-read-msg
branch
from
a52a906
to
068c6d2
Compare
|
LGTM, the mistake in tests got fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only print "Reading from /dev/stdin" message when we actually read from
stdin (and not in other cases such as ipfs add --help).
closes #3002
License: MIT
Signed-off-by: Jeromy [email protected]