cmds: implement ipfs dht provide command #3106
Conversation
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
added
need/review
| ipdht "github.com/ipfs/go-ipfs/routing/dht" | ||
| "golang.org/x/net/context" |
There was a problem hiding this comment.
This shouldn't be here.
Maybe we should wait to clear up Go 1.7 situation in #3110
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
feat/cmds/dht-provide
branch
from
25d9246
to
8aac844
Compare
|
@Kubuxu could I get some review here? Getting this in ASAP will be very helpful |
| }, | ||
|
|
||
| Arguments: []cmds.Argument{ | ||
| cmds.StringArg("key", true, true, "The key to find providers for.").EnableStdin(), |
There was a problem hiding this comment.
"The key to find providers for."...
License: MIT Signed-off-by: Jeromy <[email protected]>
| }) | ||
| } | ||
|
|
||
| err = dag.EnumerateChildrenAsync(ctx, dserv, node, kset) |
There was a problem hiding this comment.
It might be better to have just a buffered channel here instead of keyset, it looks like dag.FetchGraph could also use it, but it looks like we don't have primitive like that.
This way we could do providing at the same time of fetching recursive graph.
There was a problem hiding this comment.
Yeah, that would be nice. We should make a note to take another look at these interfaces and find better ways to do these things.
License: MIT Signed-off-by: Jeromy <[email protected]>
|
CI fails. EDIT: teamcity hit the too many open FD problem. |
|
@Kubuxu i think thats just a messed up build agent, i was working with them yesterday and the failure happened on a new one. |
|
Ok, it doesn't look like Travis will run any time in close future but Circle says ok. LGTM EDIT: Opps, wrong button. |
ghost
mentioned this pull request
closes #3099
License: MIT
Signed-off-by: Jeromy [email protected]