test: do explicit check of CORS headers #3142
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,10 +28,11 @@ thash='QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn' | |||
| test_expect_success "GET to Gateway succeeds" ' | |||
| curl -svX GET "http://127.0.0.1:$gwport/ipfs/$thash" 2>curl_output | |||
| ' | |||
| cat curl_output | |||
Kubuxu
force-pushed
the
test/CORS/defaults
branch
from
6410418
to
52f7a74
Compare
| grep "Access-Control-Allow-Origin:" curl_output && | ||
| grep "Access-Control-Allow-Methods:" curl_output && | ||
| grep "Access-Control-Allow-Origin:" curl_output | grep "\*" && | ||
| grep "Access-Control-Allow-Methods:" curl_output | grep GET && |
Kubuxu
force-pushed
the
test/CORS/defaults
branch
from
52f7a74
to
8b7a4a7
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
test/CORS/defaults
branch
from
8b7a4a7
to
3754803
Compare
Kubuxu
added
need/review
|
Resolves: #2778 |
|
What does this resolve? can you copy-paste the line or link to it in the review? or link from there to here? |
|
Okay thanks @whyrusleeping |
|
This LGTM. merge it and link to it in the review issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jakub Sztandera [email protected]