Don't drop error in readStreamedJson. #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better fix than #3230 to make sure errors from addAllAndPin make it to the client. License: MIT Signed-off-by: Kevin Atkinson <[email protected]>
kevina
added
need/review
|
@kevina can you link me to the test case for this in your other PR? |
|
@whyrusleeping This commit 6857aec contains the bulk of it, the errors are generated in |
|
Alright, then this LGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better fix than #3230 to make sure errors from addAllAndPin make it to
the client.
License: MIT
Signed-off-by: Kevin Atkinson [email protected]