Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse: Parse OSX fuse version properly #3413

Merged
merged 3 commits into from
Dec 6, 2016
Merged

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Nov 22, 2016

Resolves #3410
License: MIT
Signed-off-by: Jakub Sztandera [email protected]

@Kubuxu Kubuxu added the status/in-progress In progress label Nov 22, 2016
@victorb
Copy link
Member

victorb commented Nov 22, 2016

Tried it out with osx-fuse 3.5.3, now passing the version check but I can't get FUSE to work properly anymore. Not sure IPFS is compatible with latest osx-fuse, gonna have to let someone else to check as well.

Logs

15:05:18.280 ERROR  fuse/ipns: looking up /ipns/QmaM5uS4D4ujbL6euLKRc9d74wULSFKmWaPsBU2yzuzD7i: Could not resolve name. ipns_unix.go:99
15:05:18.280 ERROR       node: error mounting: fork/exec /Library/Filesystems/osxfusefs.fs/Support/load_osxfusefs: no such file or directory mount_unix.go:97
15:05:18.280 ERROR       node: error mounting: Could not resolve name. mount_unix.go:101
Error: fork/exec /Library/Filesystems/osxfusefs.fs/Support/load_osxfusefs: no such file or directory

@Kubuxu
Copy link
Member Author

Kubuxu commented Nov 22, 2016

Hmm, the first and last messages look like long existing bug, you can resolve it by running:
ipfs name publish QmbFMke1KXqnYyBBWxB74N4c5SBnJMVAiMNRcGu6x1AwQH

@victorb
Copy link
Member

victorb commented Nov 22, 2016

@Kubuxu yeah, that fixed the resolve error but I'm still getting this:

15:13:57.868 ERROR       node: error mounting: fork/exec /Library/Filesystems/osxfusefs.fs/Support/load_osxfusefs: no such file or directory mount_unix.go:97
15:13:57.869 ERROR       node: error mounting: fork/exec /Library/Filesystems/osxfusefs.fs/Support/load_osxfusefs: no such file or directory mount_unix.go:101
Error: fork/exec /Library/Filesystems/osxfusefs.fs/Support/load_osxfusefs: no such file or directory

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu self-assigned this Dec 5, 2016
License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu added need/review Needs a review and removed status/in-progress In progress labels Dec 5, 2016
@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 5, 2016

@whyrusleeping this should be ready for CR/merge.

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure to note that this is only a temporary restriction

@@ -54,6 +56,8 @@ It is recommended you install it from the OSXFUSE website:
For more help, see:

https://github.com/ipfs/go-ipfs/issues/177

OSXFUSE versions >3.0.0 are not compatible with version of FUSE library in current use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This will be fixed in the near future, see issue number XYZ..."

{
"author": "blang",
"hash": "QmU1N5xVAUXgo3XRTt6GhJ2SuJEbxj2zRgMS7FpjSR2U83",
"name": "semver",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not already have a semver package being used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but you use this one in gx source code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay

License: MIT
Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 5, 2016

@whyrusleeping updated

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyrusleeping whyrusleeping merged commit 6bcca84 into master Dec 6, 2016
@whyrusleeping whyrusleeping deleted the feat/fuse/osx-semver branch December 6, 2016 18:51
@ghost ghost mentioned this pull request Dec 23, 2016
@hmeine hmeine mentioned this pull request Jan 4, 2017
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants