-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuse: Parse OSX fuse version properly #3413
Conversation
Tried it out with osx-fuse 3.5.3, now passing the version check but I can't get FUSE to work properly anymore. Not sure IPFS is compatible with latest osx-fuse, gonna have to let someone else to check as well. Logs
|
Hmm, the first and last messages look like long existing bug, you can resolve it by running: |
@Kubuxu yeah, that fixed the resolve error but I'm still getting this:
|
359323e
to
08fab92
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
08fab92
to
e76b14a
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
@whyrusleeping this should be ready for CR/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make sure to note that this is only a temporary restriction
@@ -54,6 +56,8 @@ It is recommended you install it from the OSXFUSE website: | |||
For more help, see: | |||
|
|||
https://github.com/ipfs/go-ipfs/issues/177 | |||
|
|||
OSXFUSE versions >3.0.0 are not compatible with version of FUSE library in current use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This will be fixed in the near future, see issue number XYZ..."
{ | ||
"author": "blang", | ||
"hash": "QmU1N5xVAUXgo3XRTt6GhJ2SuJEbxj2zRgMS7FpjSR2U83", | ||
"name": "semver", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not already have a semver package being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but you use this one in gx source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
@whyrusleeping updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #3410
License: MIT
Signed-off-by: Jakub Sztandera [email protected]