Switch coverage to codecov from coveralls #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
As otherwise we loose .git directory which is required for Coveralls to report Coverage properly. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/cover/maybe-better
branch
2 times, most recently
from
4612400
to
ac37144
Compare
Current coverage is 34.30% (diff: 100%)
|
|
After this build passes on CircleCI it should be ready. Comments will be disabled once we merge it to master (config file). |
Will it use the github PR status then? I think it's important to show a big red flag if coverage decreases with a PR. |
|
Yes, once CircleCI goes through the build status for coverage will be shown. Disabling comments was required by @whyrusleeping |
|
The last few patches also might have to be in master. If not, I will work a bit more to get it to work. @whyrusleeping should be good to merge.' EDIT: Wait for few minutes, I might have an idea. |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/cover/maybe-better
branch
from
a92cbf2
to
ff63184
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works, coveralls stopped suddenly. It has also much nicer UI and more config options.
Still WIP, I will comment when it is ready.